Skip to content

Migrate Java 25 concurrent smoke tests#11913

Open
AlexeyKuznetsov-DD wants to merge 1 commit into
masterfrom
alexeyk/migrate-java25-concurrent-smoke-tests
Open

Migrate Java 25 concurrent smoke tests#11913
AlexeyKuznetsov-DD wants to merge 1 commit into
masterfrom
alexeyk/migrate-java25-concurrent-smoke-tests

Conversation

@AlexeyKuznetsov-DD

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD commented Jul 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

What Does This Do

Migrates the Java 25 concurrent smoke tests from Groovy/Spock to JUnit 5 Java and adds shared base classes to support Java smoke-tests migration .

Motivation

Removes the module's Java 8-only Groovy compiler workaround while keeping the broader Groovy migration incremental.

Additional Notes

  • Uses Awaitility for trace polling and a Java 25 toolchain.
  • Validated with the Java 25 concurrent smoke suite.

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD added tag: ai generated Largely based on code generated by an AI or LLM tag: no release notes Changes to exclude from release notes comp: testing Testing type: refactoring labels Jul 10, 2026
@AlexeyKuznetsov-DD AlexeyKuznetsov-DD self-assigned this Jul 10, 2026
@AlexeyKuznetsov-DD AlexeyKuznetsov-DD marked this pull request as ready for review July 10, 2026 19:31
@AlexeyKuznetsov-DD AlexeyKuznetsov-DD requested review from a team as code owners July 10, 2026 19:31
@AlexeyKuznetsov-DD AlexeyKuznetsov-DD requested review from amarziali, leoromanovsky and typotter and removed request for a team July 10, 2026 19:31
datadog-prod-us1-4[bot]
datadog-prod-us1-4 Bot reviewed Jul 10, 2026
View reviewed changes

@datadog-prod-us1-4 datadog-prod-us1-4 Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: PASS

More details

Migration from Groovy/Spock to JUnit 5 Java passes validation. The Java smoke tests are functionally equivalent to the Groovy originals with improved null safety (Optional return types, Objects.equals) and stricter span count assertions that match the expected @WithSpan annotations in test applications. Removed Java 8-only Groovy compiler workaround cleanly.

Was this helpful? React 👍 or 👎

📊 Validated against 5 scenarios · Open Bits AI session

🤖 Datadog Autotest · Commit 4738d4a · What is Autotest? · Any feedback? Reach out in #autotest

@datadog-prod-us1-4

datadog-prod-us1-4 Bot commented Jul 10, 2026 •
edited by datadog-official Bot
Loading

Copy link
Copy Markdown

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 57.03% (-0.01%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 4738d4a | Docs | Datadog PR Page | Give us feedback!

@dd-octo-sts

dd-octo-sts Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 13.97 s 13.95 s [-0.7%; +0.9%] (no difference)
startup:insecure-bank:tracing:Agent 12.99 s 13.05 s [-1.4%; +0.5%] (no difference)
startup:petclinic:appsec:Agent 17.00 s 16.88 s [-0.3%; +1.7%] (no difference)
startup:petclinic:iast:Agent 16.97 s 17.00 s [-1.1%; +0.7%] (no difference)
startup:petclinic:profiling:Agent 16.89 s 16.78 s [-0.3%; +1.6%] (no difference)
startup:petclinic:sca:Agent 17.04 s 16.89 s [-0.3%; +2.0%] (no difference)
startup:petclinic:tracing:Agent 16.06 s 16.14 s [-1.5%; +0.4%] (no difference)

Commit: 4738d4a9 · CI Pipeline · Benchmarking Platform UI

Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

typotter
typotter approved these changes Jul 10, 2026
View reviewed changes

@typotter typotter left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm for flagging. thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@datadog-prod-us1-4 datadog-prod-us1-4[bot] datadog-prod-us1-4[bot] left review comments
@typotter typotter typotter approved these changes
@leoromanovsky leoromanovsky Awaiting requested review from leoromanovsky leoromanovsky is a code owner automatically assigned from DataDog/feature-flagging-and-experimentation-sdk
@amarziali amarziali Awaiting requested review from amarziali amarziali is a code owner automatically assigned from DataDog/apm-lang-platform-java

Assignees

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD

Labels

comp: testing Testing tag: ai generated Largely based on code generated by an AI or LLM tag: no release notes Changes to exclude from release notes type: refactoring

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AlexeyKuznetsov-DD @typotter